From a65bb06754e237a603d8fd4b232f7b8443aefba2 Mon Sep 17 00:00:00 2001
From: Felix Linker <linkerfelix@gmail.com>
Date: Mon, 1 Feb 2021 22:40:01 +0100
Subject: [PATCH] Implement tooltips for experimental effects

---
 src/app/components/ModificationsMenu.jsx | 14 ++---
 src/app/utils/BlueprintFunctions.js      | 74 +++++++++---------------
 2 files changed, 31 insertions(+), 57 deletions(-)

diff --git a/src/app/components/ModificationsMenu.jsx b/src/app/components/ModificationsMenu.jsx
index 2f06005f..006ffd95 100644
--- a/src/app/components/ModificationsMenu.jsx
+++ b/src/app/components/ModificationsMenu.jsx
@@ -102,21 +102,15 @@ export default class ModificationsMenu extends TranslatedComponent {
     const experimentals = [];
     for (const experimental of m.getApplicableExperimentals()) {
       const active = experimental === applied;
-      // TODO:
-      // let specialTt = specialToolTip(
-      //   translate,
-      //   m.blueprint.grades[m.blueprint.grade],
-      //   m.grp, m,
-      //   experimental,
-      // );
+      let specialTt = specialToolTip(language, m, experimental);
       experimentals.push(
         <div key={experimental} data-id={experimental}
           style={{ cursor: 'pointer' }}
           className={cn('button-inline-menu', { active })}
           onClick={this._specialSelected(experimental)}
           ref={active ? (ref) => { this.selectedSpecialRef = ref; } : undefined}
-          // onMouseOver={termtip.bind(null, specialTt)}
-          // onMouseOut={tooltip.bind(null, null)}
+          onMouseOver={termtip.bind(null, specialTt)}
+          onMouseOut={tooltip.bind(null, null)}
         >{translate(experimental)}</div>
       );
     }
@@ -273,7 +267,7 @@ export default class ModificationsMenu extends TranslatedComponent {
           let specialTt;
           if (appliedExperimental) {
             specialLabel = appliedExperimental;
-            // specialTt = specialToolTip(translate, m.blueprint.grades[m.blueprint.grade], m.grp, m, m.blueprint.special.edname);
+            specialTt = specialToolTip(language, m, appliedExperimental);
           }
           renderComponents.push(
             <div className="section-menu button-inline-menu"
diff --git a/src/app/utils/BlueprintFunctions.js b/src/app/utils/BlueprintFunctions.js
index 4a727039..7f1c7aa5 100644
--- a/src/app/utils/BlueprintFunctions.js
+++ b/src/app/utils/BlueprintFunctions.js
@@ -1,63 +1,43 @@
 import React from 'react';
 import { Modifications } from 'coriolis-data/dist';
 import { Module } from 'ed-forge';
-import { getBlueprintInfo } from 'ed-forge/lib/data/blueprints';
-import { keys, uniq } from 'lodash';
+import { getBlueprintInfo, getExperimentalInfo } from 'ed-forge/lib/data/blueprints';
+import { entries, keys, uniq } from 'lodash';
 
 /**
  * Generate a tooltip with details of a blueprint's specials
- * @param   {Object}  translate   The translate object
- * @param   {Object}  blueprint   The blueprint at the required grade
- * @param   {string}  grp         The group of the module
- * @param   {Object}  m           The module to compare with
+ * @param   {Object} language   The translate object
+ * @param   {Module} m           The module to compare with
  * @param   {string} specialName  The name of the special
  * @returns {Object}              The react components
  */
-export function specialToolTip(translate, blueprint, grp, m, specialName) {
-  const effects = [];
-  if (!blueprint || !blueprint.features) {
-    return undefined;
-  }
-  if (m) {
-    // We also add in any benefits from specials that aren't covered above
-    if (m.blueprint) {
-      for (const feature in Modifications.modifierActions[specialName]) {
-        // if (!blueprint.features[feature] && !m.mods.feature) {
-        const featureDef = Modifications.modifications[feature];
-        if (featureDef && !featureDef.hidden) {
-          let symbol = '';
-          if (feature === 'jitter') {
-            symbol = '°';
-          } else if (featureDef.type === 'percentage') {
-            symbol = '%';
-          }
-          let current = m.getModValue(feature) - m.getModValue(feature, true);
-          if (featureDef.type === 'percentage') {
-            current = Math.round(current / 10) / 10;
-          } else if (featureDef.type === 'numeric') {
-            current /= 100;
-          }
-          const currentIsBeneficial = isValueBeneficial(feature, current);
-
-          effects.push(
-            <tr key={feature + '_specialTT'}>
-              <td style={{ textAlign: 'left' }}>{translate(feature, grp)}</td>
-              <td>&nbsp;</td>
-              <td className={current === 0 ? '' : currentIsBeneficial ? 'secondary' : 'warning'}
-                style={{ textAlign: 'right' }}>{current}{symbol}</td>
-              <td>&nbsp;</td>
-            </tr>
-          );
-        }
-      }
-    }
-  }
-
+export function specialToolTip(language, m, specialName) {
+  const { formats, translate } = language;
   return (
     <div>
       <table width='100%'>
         <tbody>
-          {effects}
+          {entries(getExperimentalInfo(specialName).features).map(
+            ([prop, feats]) => {
+              const { max, only } = feats;
+              if (only && !m.getItem().match(only)) {
+                return null;
+              }
+
+              const { value, unit, beneficial } = m.getModifierFormatted(prop);
+              // If the product of value and min/max is positive, both values
+              // point into the same direction, i.e. positive/negative.
+              const specialBeneficial  = (value * max) > 0 === beneficial;
+
+              return <tr key={prop + '_specialTT'}>
+                <td style={{ textAlign: 'left' }}>{translate(prop)}</td>
+                <td>&nbsp;</td>
+                <td className={specialBeneficial ? 'secondary' : 'warning'}
+                  style={{ textAlign: 'right' }}>{formats.round(max * 100)}{unit}</td>
+                <td>&nbsp;</td>
+              </tr>;
+            }
+          )}
         </tbody>
       </table>
     </div>