Mirroring/coriolis
1
0
Fork 0
mirror of https://github.com/EDCD/coriolis.git synced 2025-12-11 08:43:02 +00:00
Code Issues Projects Releases Wiki Activity

Fix burst(rof) modding and burst sdps calculation

Browse Source 
References #504 #388
This commit is contained in:
felixlinker
2019-05-17 21:02:17 +02:00
parent 94980270c4
commit c610eb8627
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/app/shipyard/Module.js
View File

@@ -263,10 +263,10 @@ export default class Module {
} }
result = result * (1 + modValue); result = result * (1 + modValue);
} }
} else if (name === 'burstrof') { } else if (name === 'burstrof' || name === 'burst') {
// Burst and burst rate of fire are special, as it can not exist but // Burst and burst rate of fire are special, as it can not exist but
// have a modification // have a modification
result = modValue / 100; result = modValue;
} }
} }
} }
@@ -832,9 +832,12 @@ export default class Module {
clipSize += clipSize - 1; clipSize += clipSize - 1;
} }
let volleys = clipSize / (this.get('burst', modified) || 1); let burstSize = this.get('burst', modified) || 1;
let rof = this.getRoF(modified); let rof = this.getRoF(modified);
let srof = volleys / ((volleys - 1) / rof + this.getReload(modified)); // rof averages burstfire + pause until next interval but for sustained
// rof we need to take another burst without pause into account
let burstOverhead = (burstSize - 1) / (this.get('burstrof', modified) || 1);
let srof = clipSize / ((clipSize - burstSize) / rof + burstOverhead + this.getReload(modified));
return dps * srof / rof; return dps * srof / rof;
} else { } else {
return dps; return dps;