mirror of
https://github.com/EDCD/coriolis.git
synced 2025-12-08 22:33:24 +00:00
These changes fix the issue where MC's with the Weapon_Overcharged blueprint, don't properly show the blueprint because of the Laser Weapon_Overcharged blueprint being a conflict.
This commit is contained in:
@@ -57,6 +57,7 @@ export default class ModificationsMenu extends TranslatedComponent {
|
|||||||
this.modValDidChange = false; // used to determine if component update was caused by change in modification value.
|
this.modValDidChange = false; // used to determine if component update was caused by change in modification value.
|
||||||
this._handleModChange = this._handleModChange.bind(this);
|
this._handleModChange = this._handleModChange.bind(this);
|
||||||
|
|
||||||
|
// console.log(props.m.blueprint)
|
||||||
this.state = {
|
this.state = {
|
||||||
blueprintMenuOpened: !(props.m.blueprint && props.m.blueprint.name),
|
blueprintMenuOpened: !(props.m.blueprint && props.m.blueprint.name),
|
||||||
specialMenuOpened: false
|
specialMenuOpened: false
|
||||||
@@ -421,15 +422,28 @@ export default class ModificationsMenu extends TranslatedComponent {
|
|||||||
let haveBlueprint = false;
|
let haveBlueprint = false;
|
||||||
let blueprintTt;
|
let blueprintTt;
|
||||||
let blueprintCv;
|
let blueprintCv;
|
||||||
|
|
||||||
|
// Set the bprintSearchName value to the fdname of the blueprint for this module
|
||||||
|
let bprintSearchName = m.blueprint.fdname;
|
||||||
|
// If the fdname is Weapon_Overcharged, we need to check if it's an MC
|
||||||
|
if (m.blueprint.fdname === 'Weapon_Overcharged') {
|
||||||
|
// If the module is a MultiCannon, we need to fix the blueprint search name, else it will find the Laser Weapon_Overcharged Blueprint and not the MC Weapon_Overcharged Blueprint
|
||||||
|
if (m.symbol.match(/MultiCannon/i)) {
|
||||||
|
console.log(Modifications.modules[m.grp].blueprints['MC_Overcharged']);
|
||||||
|
console.log(m.blueprint.fdname);
|
||||||
|
bprintSearchName = 'MC_Overcharged';
|
||||||
|
}
|
||||||
|
}
|
||||||
// TODO: Fix this to actually find the correct blueprint.
|
// TODO: Fix this to actually find the correct blueprint.
|
||||||
if (!m.blueprint || !m.blueprint.name || !m.blueprint.fdname || !Modifications.modules[m.grp].blueprints || !Modifications.modules[m.grp].blueprints[m.blueprint.fdname]) {
|
if (!m.blueprint || !m.blueprint.name || !m.blueprint.fdname || !Modifications.modules[m.grp].blueprints || !Modifications.modules[m.grp].blueprints[bprintSearchName]) {
|
||||||
this.props.ship.clearModuleBlueprint(m);
|
this.props.ship.clearModuleBlueprint(m);
|
||||||
this.props.ship.clearModuleSpecial(m);
|
this.props.ship.clearModuleSpecial(m);
|
||||||
}
|
}
|
||||||
if (m.blueprint && m.blueprint.name && Modifications.modules[m.grp].blueprints[m.blueprint.fdname].grades[m.blueprint.grade]) {
|
if (m.blueprint && m.blueprint.name && Modifications.modules[m.grp].blueprints[bprintSearchName].grades[m.blueprint.grade]) {
|
||||||
blueprintLabel = translate(m.blueprint.name) + ' ' + translate('grade') + ' ' + m.blueprint.grade;
|
blueprintLabel = translate(m.blueprint.name) + ' ' + translate('grade') + ' ' + m.blueprint.grade;
|
||||||
haveBlueprint = true;
|
haveBlueprint = true;
|
||||||
blueprintTt = blueprintTooltip(translate, m.blueprint.grades[m.blueprint.grade], Modifications.modules[m.grp].blueprints[m.blueprint.fdname].grades[m.blueprint.grade].engineers, m.grp);
|
console.log(haveBlueprint);
|
||||||
|
blueprintTt = blueprintTooltip(translate, m.blueprint.grades[m.blueprint.grade], Modifications.modules[m.grp].blueprints[bprintSearchName].grades[m.blueprint.grade].engineers, m.grp);
|
||||||
blueprintCv = getPercent(m);
|
blueprintCv = getPercent(m);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -307,10 +307,22 @@ export function isChangeValueBeneficial(feature, value) {
|
|||||||
* @returns {Object} The matching blueprint
|
* @returns {Object} The matching blueprint
|
||||||
*/
|
*/
|
||||||
export function getBlueprint(name, module) {
|
export function getBlueprint(name, module) {
|
||||||
|
// Special case for multi-cannons. Conflicting 'Weapon_Overcharged' Blueprints exist due to FD's naming conventions. If this blueprint is for a multi-cannon, we need to use the correct blueprint.
|
||||||
|
if (name === 'weapon_overcharged') {
|
||||||
|
if (module.symbol.match(/MultiCannon/i)) {
|
||||||
|
name = 'mc_overcharged';
|
||||||
|
}
|
||||||
|
}
|
||||||
|
else if (name === 'Weapon_Overcharged') {
|
||||||
|
if (module.symbol.match(/MultiCannon/i)) {
|
||||||
|
name = 'MC_Overcharged';
|
||||||
|
}
|
||||||
|
}
|
||||||
// Start with a copy of the blueprint
|
// Start with a copy of the blueprint
|
||||||
const findMod = val => Object.keys(Modifications.blueprints).find(elem => elem.toString().toLowerCase().search(val.toString().toLowerCase().replace(/(OutfittingFieldType_|persecond)/igm, '')) >= 0);
|
const findMod = val => Object.keys(Modifications.blueprints).find(elem => elem.toString().toLowerCase().search(val.toString().toLowerCase().replace(/(OutfittingFieldType_|persecond)/igm, '')) >= 0);
|
||||||
const found = Modifications.blueprints[findMod(name)];
|
const found = Modifications.blueprints[findMod(name)];
|
||||||
if (!found || !found.fdname) {
|
if (!found || !found.fdname) {
|
||||||
|
console.error('Blueprint not found:', name);
|
||||||
return {};
|
return {};
|
||||||
}
|
}
|
||||||
const blueprint = JSON.parse(JSON.stringify(found));
|
const blueprint = JSON.parse(JSON.stringify(found));
|
||||||
|
|||||||
@@ -349,6 +349,7 @@ function _addModifications(module, modifiers, quality, blueprint, grade, special
|
|||||||
// Add the blueprint definition, grade and special
|
// Add the blueprint definition, grade and special
|
||||||
if (blueprint) {
|
if (blueprint) {
|
||||||
module.blueprint = getBlueprint(blueprint, module);
|
module.blueprint = getBlueprint(blueprint, module);
|
||||||
|
|
||||||
if (grade) {
|
if (grade) {
|
||||||
module.blueprint.grade = Number(grade);
|
module.blueprint.grade = Number(grade);
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user