feat: stop force redirect to create collection form

app/collections/controllers/show_collections_controller.ts

@@ -19,10 +19,6 @@ export default class ShowCollectionsController {
 			this.linkService.getFavoriteLinksForAuthenticatedUser(),
 		]);
 
-		if (collections.length === 0) {
-			return response.redirectToNamedRoute('collection.create-form');
-		}
-
 		const activeCollection = collections.find(
 			(c) => c.id === activeCollectionId
 		);

inertia/components/dashboard/link/list/link_list.tsx

@@ -1,5 +1,5 @@
 import { DisplayPreferences } from '#shared/types/index';
-import { SimpleGrid, Stack, StyleProp, useCombobox } from '@mantine/core';
+import { SimpleGrid, Stack, StyleProp } from '@mantine/core';
 import { LinkItem } from '~/components/dashboard/link/item/link_item';
 import { NoLink } from '~/components/dashboard/link/no_link/no_link';
 import { useActiveCollection } from '~/hooks/collections/use_active_collection';
@@ -15,13 +15,9 @@ export function LinkList({ hideMenu = false }: LinkListProps) {
 	const favoriteLinks = useFavoriteLinks();
 	const { displayPreferences } = useDisplayPreferences();
 
-	const combobox = useCombobox({
-		onDropdownClose: () => combobox.resetSelectedOption(),
-	});
-
 	const links = activeCollection?.links || favoriteLinks;
 
-	if (activeCollection?.links.length === 0) {
+	if (links.length === 0) {
 		return <NoLink hideMenu={hideMenu} />;
 	}
 

inertia/components/dashboard/link/no_link/no_link.tsx

@@ -12,21 +12,27 @@ interface NoLinkProps extends LinkListProps {}
 export function NoLink({ hideMenu }: NoLinkProps) {
 	const { t } = useTranslation('common');
 	const activeCollection = useActiveCollection();
-	return (
-		<Box className={styles.noCollection} p="xl">
-			<Text
-				className={styles.text}
-				dangerouslySetInnerHTML={{
-					__html: t(
+	const isFavorite = !activeCollection?.id;
+
+	const noLinkForCollection = t(
 		'home:no-link',
 		{ name: activeCollection?.name ?? '' } as any,
 		{
 			interpolation: { escapeValue: false },
 		}
-					),
+	);
+
+	const noLinkForFavorite = t('home:no-link-favorite');
+
+	return (
+		<Box className={styles.noCollection} p="xl">
+			<Text
+				className={styles.text}
+				dangerouslySetInnerHTML={{
+					__html: isFavorite ? noLinkForFavorite : noLinkForCollection,
 				}}
 			/>
-			{!hideMenu && (
+			{!hideMenu && !isFavorite && (
 				<Anchor
 					component={Link}
 					href={appendCollectionId(

inertia/i18n/locales/en/home.json

@@ -1,5 +1,6 @@
 {
 	"select-collection": "Please select a collection",
 	"or-create-one": "or create one",
-  "no-link": "No link for <b>{{name}}</b>"
+	"no-link": "No link for <b>{{name}}</b>",
+	"no-link-favorite": "No favorite link"
 }

inertia/i18n/locales/fr/home.json

@@ -1,5 +1,6 @@
 {
 	"select-collection": "Veuillez sélectionner une collection",
 	"or-create-one": "ou en créer une",
-  "no-link": "Aucun lien pour <b>{{name}}</b>"
+	"no-link": "Aucun lien pour <b>{{name}}</b>",
+	"no-link-favorite": "Aucun lien dans les favoris"
 }

inertia/pages/dashboard.tsx

@@ -39,13 +39,15 @@ export default function Dashboard() {
 						disabled
 					/>
 				</Tooltip>
-				{!isFavorite && (
 				<Group>
-						{activeCollection?.visibility === Visibility.PUBLIC && (
+					{!isFavorite &&
+						activeCollection?.visibility === Visibility.PUBLIC && (
+							<>
 								<SharedCollectionCopyLink />
+								<Divider orientation="vertical" />
+							</>
 						)}
 
-						<Divider orientation="vertical" />
 					<Button
 						variant="outline"
 						component={Link}
@@ -57,6 +59,7 @@ export default function Dashboard() {
 					>
 						{t('collection.create')}
 					</Button>
+					{!isFavorite && (
 						<Button
 							variant="outline"
 							component={Link}
@@ -68,7 +71,10 @@ export default function Dashboard() {
 						>
 							{t('collection.edit')}
 						</Button>
+					)}
 
+					{!isFavorite && (
+						<>
 							<Divider orientation="vertical" />
 							<Button
 								variant="light"
@@ -81,9 +87,10 @@ export default function Dashboard() {
 							>
 								{t('link.create')}
 							</Button>
-					</Group>
+						</>
 					)}
 				</Group>
+			</Group>
 			{displayPreferences.collectionListDisplay === 'inline' && !isMobile && (
 				<InlineCollectionList />
 			)}