From 97813632822aac01bceb500d694258ef15999d63 Mon Sep 17 00:00:00 2001 From: Sonny Date: Fri, 8 Nov 2024 18:19:37 +0100 Subject: [PATCH] fix: trim values before form validation --- inertia/pages/collections/edit.tsx | 8 +++++--- inertia/pages/links/edit.tsx | 14 +++++++++----- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/inertia/pages/collections/edit.tsx b/inertia/pages/collections/edit.tsx index 5adee64..bb23008 100644 --- a/inertia/pages/collections/edit.tsx +++ b/inertia/pages/collections/edit.tsx @@ -21,11 +21,13 @@ export default function EditCollectionPage({ nextId: collection.nextId, }); const canSubmit = useMemo(() => { + const trimmedName = data.name.trim(); + const trimmedDescription = data.description?.trim(); const isFormEdited = - data.name !== collection.name || - data.description !== collection.description || + trimmedName !== collection.name || + trimmedDescription !== collection.description || data.visibility !== collection.visibility; - const isFormValid = data.name !== ''; + const isFormValid = trimmedName !== ''; return isFormEdited && isFormValid && !processing; }, [data, collection]); diff --git a/inertia/pages/links/edit.tsx b/inertia/pages/links/edit.tsx index 774161e..8bb296a 100644 --- a/inertia/pages/links/edit.tsx +++ b/inertia/pages/links/edit.tsx @@ -22,16 +22,20 @@ export default function EditLinkPage({ collectionId: link.collectionId, }); const canSubmit = useMemo(() => { + const trimmedName = data.name.trim(); + const trimmedDescription = data.description?.trim(); + const trimmedUrl = data.url.trim(); + const isFormEdited = - data.name !== link.name || - data.url !== link.url || - data.description !== link.description || + trimmedName !== link.name || + trimmedUrl !== link.url || + trimmedDescription !== link.description || data.favorite !== link.favorite || data.collectionId !== link.collectionId; const isFormValid = - data.name !== '' && - isValidHttpUrl(data.url) && + trimmedName !== '' && + isValidHttpUrl(trimmedUrl) && data.favorite !== null && data.collectionId !== null;