From 62d19e5cc1fceb5b84c5faf80c2f189004f54e48 Mon Sep 17 00:00:00 2001 From: Max Shytikov Date: Wed, 30 Apr 2014 04:06:14 +0200 Subject: [PATCH] Update _remove_headers to work with headers copy Because of the filter implementation here we nedd to work only with clone of the headers and request. subj to refactor --- vcr/filters.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/vcr/filters.py b/vcr/filters.py index b9c8b0e..0b9802a 100644 --- a/vcr/filters.py +++ b/vcr/filters.py @@ -3,10 +3,13 @@ import copy def _remove_headers(request, headers_to_remove): + headers = copy.copy(request.headers) headers_to_remove = [h.lower() for h in headers_to_remove] - keys = [k for k in request.headers if k.lower() in headers_to_remove] - for k in keys: - request.headers.pop(k) + keys = [k for k in headers if k.lower() in headers_to_remove] + if keys: + for k in keys: + headers.pop(k) + request.headers = headers return request