1
0
mirror of https://github.com/kevin1024/vcrpy.git synced 2025-12-10 09:35:34 +00:00

Only use the relative path in HTTP requests

This causes a pretty big problem on out-of-spec HTTP servers (like
Flickr). Closes #31
This commit is contained in:
Kevin McCarthy
2013-09-17 13:18:26 -10:00
parent ce3d7270ea
commit 912452e863
4 changed files with 11 additions and 3 deletions

View File

@@ -259,6 +259,8 @@ This library is a work in progress, so the API might change on you.
There are probably some [bugs](https://github.com/kevin1024/vcrpy/issues?labels=bug&page=1&state=open) floating around too. There are probably some [bugs](https://github.com/kevin1024/vcrpy/issues?labels=bug&page=1&state=open) floating around too.
##Changelog ##Changelog
* 0.3.1: Fix issue causing full paths to be sent on the HTTP request
line.
* 0.3.0: *Backwards incompatible release* - Added support for record * 0.3.0: *Backwards incompatible release* - Added support for record
modes, and changed the default recording behavior to the "once" record modes, and changed the default recording behavior to the "once" record
mode. Please see the documentation on record modes for more. Added mode. Please see the documentation on record modes for more. Added

View File

@@ -19,7 +19,7 @@ class PyTest(TestCommand):
sys.exit(errno) sys.exit(errno)
setup(name='vcrpy', setup(name='vcrpy',
version='0.3.0', version='0.3.1',
description="A Python port of Ruby's VCR to make mocking HTTP easier", description="A Python port of Ruby's VCR to make mocking HTTP easier",
author='Kevin McCarthy', author='Kevin McCarthy',
author_email='me@kevinmccarthy.org', author_email='me@kevinmccarthy.org',

View File

@@ -45,3 +45,9 @@ def test_flickr_multipart_upload():
assert len(cass) == 1 assert len(cass) == 1
_pretend_to_be_flickr_library() _pretend_to_be_flickr_library()
assert cass.play_count == 1 assert cass.play_count == 1
def test_flickr_should_respond_with_200(tmpdir):
testfile = str(tmpdir.join('flickr.yml'))
with vcr.use_cassette(testfile):
r = requests.post("http://api.flickr.com/services/upload")
assert r.status_code == 200

View File

@@ -79,7 +79,7 @@ class VCRConnectionMixin:
def _send_request(self, method, url, body, headers): def _send_request(self, method, url, body, headers):
""" """
Coppy+pasted from python stdlib 2.6 source because it Copy+pasted from python stdlib 2.6 source because it
has a call to self.send() which I have overridden has a call to self.send() which I have overridden
#stdlibproblems #fml #stdlibproblems #fml
""" """
@@ -160,7 +160,7 @@ class VCRConnectionMixin:
self._baseclass.request( self._baseclass.request(
self, self,
method=self._vcr_request.method, method=self._vcr_request.method,
url=self._vcr_request.url, url=self._vcr_request.path,
body=self._vcr_request.body, body=self._vcr_request.body,
headers=dict(self._vcr_request.headers or {}) headers=dict(self._vcr_request.headers or {})
) )