Mirroring/vcrpy
1
0
Fork 0
mirror of https://github.com/kevin1024/vcrpy.git synced 2025-12-10 09:35:34 +00:00
Code Releases Activity

Add TODO and elaborate on comment

Browse Source
This commit is contained in:
Tye Wang
2015-09-18 12:19:17 -04:00
parent 79ff59feae
commit ac510097e0
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
vcr/stubs/__init__.py
View File

@@ -323,10 +323,15 @@ class VCRConnection(object):
For example, urllib3 will set certain attributes on the connection, For example, urllib3 will set certain attributes on the connection,
such as 'ssl_version'. These attributes need to get set on the real such as 'ssl_version'. These attributes need to get set on the real
connection to have the correct and expected behavior. connection to have the correct and expected behavior.
TODO: Separately setting the attribute on the two instances is not
ideal. We should switch to a proxying implementation.
""" """
try: try:
setattr(self.real_connection, name, value) setattr(self.real_connection, name, value)
except AttributeError: # raised if real_connection has not been set yet except AttributeError:
# raised if real_connection has not been set yet, such as when
# we're setting the real_connection itself for the first time
pass pass
super(VCRConnection, self).__setattr__(name, value) super(VCRConnection, self).__setattr__(name, value)