From 640681138a1a010f72603acf4f1923a8701697e5 Mon Sep 17 00:00:00 2001 From: Ivan Malison Date: Fri, 12 Sep 2014 02:16:32 -0700 Subject: [PATCH] Make defaults of Cassette constructor immutable. Clean up whitespace. Remove unused import. --- vcr/cassette.py | 10 +++++----- vcr/compat/counter.py | 6 +++--- vcr/persisters/filesystem.py | 1 - 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/vcr/cassette.py b/vcr/cassette.py index c4d9c20..36deed3 100644 --- a/vcr/cassette.py +++ b/vcr/cassette.py @@ -30,12 +30,12 @@ class Cassette(ContextDecorator): path, serializer=yamlserializer, record_mode='once', - match_on=[uri, method], - filter_headers=[], - filter_query_parameters=[], + match_on=(uri, method), + filter_headers=(), + filter_query_parameters=(), before_record=None, - ignore_hosts=[], - ignore_localhost=[], + ignore_hosts=(), + ignore_localhost=() ): self._path = path self._serializer = serializer diff --git a/vcr/compat/counter.py b/vcr/compat/counter.py index a28bf23..8833bbd 100644 --- a/vcr/compat/counter.py +++ b/vcr/compat/counter.py @@ -26,7 +26,7 @@ class Counter(dict): >>> c = Counter({'a': 4, 'b': 2}) # a new counter from a mapping >>> c = Counter(a=4, b=2) # a new counter from keyword args - ''' + ''' self.update(iterable, **kwds) def __missing__(self, key): @@ -39,7 +39,7 @@ class Counter(dict): >>> Counter('abracadabra').most_common(3) [('a', 5), ('r', 2), ('b', 2)] - ''' + ''' if n is None: return sorted(self.iteritems(), key=itemgetter(1), reverse=True) return nlargest(n, self.iteritems(), key=itemgetter(1)) @@ -78,7 +78,7 @@ class Counter(dict): >>> c['h'] # four 'h' in which, witch, and watch 4 - ''' + ''' if iterable is not None: if hasattr(iterable, 'iteritems'): if self: diff --git a/vcr/persisters/filesystem.py b/vcr/persisters/filesystem.py index 9b00fa0..884d891 100644 --- a/vcr/persisters/filesystem.py +++ b/vcr/persisters/filesystem.py @@ -1,4 +1,3 @@ -import tempfile import os