The initial technique to implement `record_on_exception=False` was to
not emptying the generator returned by
`CassetteContextDecorator._patch_generator` when an exception happens to
skip the `cassette._save` call, however this had the side effect of not
emptying the `ExitStack` created inside the generator which contains the
`_patch.__exit__` calls to remove the patches.
This was innocuous in CPython, which uses a reference counting garbage
collector so the `ExitStack` was immediately collected after losing
scope and therefore its `__exit__` method executed.
Pypy, on the other hand, uses a generational garbage collector so its
objects may survive more time, enough for the `ExitStack` not called
until much later, which may cause the patches to live more than expected
when `record_on_exception=False`.
This was found because the test
`test_nesting_context_managers_by_checking_references_of_http_connection`
was failing because it was executed after
`test_dont_record_on_exception`.
Now the cassette instance is saved inside the `CassetteContextDecorator`
instance to have better control on where to save the cassette, and moved
the `cassette._save` call from the `_patch_generator` method to the
`__exit__` method to be free to empty the generator and remove the
patches always.
* Drop support for legacy Python 2.7
* Upgrade Python syntax with pyupgrade --py3-plus
* Trim testing matrix to remove python2
* re-enable python3.8 in travis as tests that are not allowed to fail
* Remove some six
* The future is now
* Remove Python 2 imports
* Add back example, but change py27 to py36
* Remove redundant compat.py
* Blacken
* Credit hugovk in changelog
WIP Updating Sphinx Docs and AutoDoc
* Fix AutoDoc and update Sphinx theme to python_doc_theme
* Fix#420, autodoc even undocumented (docstring-less) method signatures
* Doc theme 'nature'. Add global TOC to doc sidebar
* Comment last reference to package six
* Changelog is now a consistent format
* Yet another documentation fix for links and title hierarchy
* Start work on new SVG logo
test SVG in README
trying to test new SVG logo in README
Apply centering
Apply readme logo centering
Trying to align image
Trying random shit
trying align right
add emoji
Large logo has higher priority
Change title hierarchy
Actually use a H1
Try again
try and organise badges
revert link back to point at master
* updated new take on VCR logo as SVG code
* Testing modern logo in docs
* Add sanitize for rendering SVG
* Switch to alabaster theme
* Update vcrpy logo (#503)
* Add credit for V4 logo changes.
* Add rewind and play animation
* Add svg into ReadTheDocs static assets so that it can be hosted so the animations work.
* Need to embedd the SVG for ReadTheDocs somewhere so I can get the link to later embed in the README
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Sean Bailey <sean@seanbailey.io>
Format with line length 110 to match flake8
make black part of linting check
Update travis spec for updated black requirements
Add diff output for black on failure
update changelog
When no cassette exists, it's expected that the response returned, should be
the original, unchanged response. The response recorded in the cassette should be
that which is returned by the before_record_response callback.
But on subsequent requests/responses (when a cassette exists), the responses
returned should be exactly what is in the cassette.
resolves#355
Whilst working on the Reproducible Builds effort [0], we noticed
that vcrpy could not be built reproducibly.
This is due to the documentation including the absolute build path
via Python default arguments.
This was originally filed in Debian as #895269 [1].
[0] https://reproducible-builds.org/
[1] https://bugs.debian.org/895269
Signed-off-by: Chris Lamb <lamby@debian.org>
