This PR fixes issue #710 by properly closing the underlying socket. It
first uses `pool._put_conn` to keep the connection in the pool, and
later removes and closes it when the context manager exits.
I was unsure about the exact purpose of the `ConnectonRemove` class,
so I made minimal changes to minimize the risk of breaking the code
and there may be better solutions for fixing this issue.
For example, the `urllib3.connectionpool.HTTPConnectionPool` will
utilize a weakref to terminate pool connections. By appending our
connection to it, it will also take care of closing our connection. So
another solution could be to modify the `__exit__` in
`patch.ConnectionRemover` method and add our connection to the pool:
```py
class ConnectionRemover:
...
def __exit__(self, *args):
for pool, connections in self._connection_pool_to_connections.items():
for connection in connections:
if isinstance(connection, self._connection_class):
pool._put_conn(connection)
```
Since urllib3 v2 the re-export of connection.HTTPConnection in
urllib3.connectionpool was removed.
In this commit we use urllib3.connection where needed. Some references
to connectionpool.HTTPConnection are still there for backward
compatibility.
Closes#688
* Drop support for legacy Python 2.7
* Upgrade Python syntax with pyupgrade --py3-plus
* Trim testing matrix to remove python2
* re-enable python3.8 in travis as tests that are not allowed to fail
* Remove some six
* The future is now
* Remove Python 2 imports
* Add back example, but change py27 to py36
* Remove redundant compat.py
* Blacken
* Credit hugovk in changelog
WIP Updating Sphinx Docs and AutoDoc
* Fix AutoDoc and update Sphinx theme to python_doc_theme
* Fix#420, autodoc even undocumented (docstring-less) method signatures
* Doc theme 'nature'. Add global TOC to doc sidebar
* Comment last reference to package six
* Changelog is now a consistent format
* Yet another documentation fix for links and title hierarchy
* Start work on new SVG logo
test SVG in README
trying to test new SVG logo in README
Apply centering
Apply readme logo centering
Trying to align image
Trying random shit
trying align right
add emoji
Large logo has higher priority
Change title hierarchy
Actually use a H1
Try again
try and organise badges
revert link back to point at master
* updated new take on VCR logo as SVG code
* Testing modern logo in docs
* Add sanitize for rendering SVG
* Switch to alabaster theme
* Update vcrpy logo (#503)
* Add credit for V4 logo changes.
* Add rewind and play animation
* Add svg into ReadTheDocs static assets so that it can be hosted so the animations work.
* Need to embedd the SVG for ReadTheDocs somewhere so I can get the link to later embed in the README
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Sean Bailey <sean@seanbailey.io>
Format with line length 110 to match flake8
make black part of linting check
Update travis spec for updated black requirements
Add diff output for black on failure
update changelog
The new version of requests un-vendors urllib3, with a nifty hack:
https://github.com/kennethreitz/requests/blob/master/requests/packages.py
Unfortunately messing directly with sys.modules causes some weird
behavior that I don't entirely understand. Avoiding the extra import to
requests.packages as part of VCR's initialization seems to sidestep the
issue.
Closes#311
