From 2d48a37ccbbf226635ee35af26d9e95d4eeb0b59 Mon Sep 17 00:00:00 2001 From: "Maxence G. de Montauzan" Date: Sat, 16 Dec 2023 03:01:38 +0100 Subject: [PATCH] Improve HTML template + improve links Reduce size (from ~15kB to ~4kB) Reduce incompatibility for emails Link to project on project name --- notifier.py | 17 ++++++--- template.html | 95 ++++++++++++++++++--------------------------------- 2 files changed, 46 insertions(+), 66 deletions(-) diff --git a/notifier.py b/notifier.py index d576fb0..2acc741 100644 --- a/notifier.py +++ b/notifier.py @@ -70,18 +70,18 @@ def main(): for new_r in new_releases: content += f""" -
  • {new_r["project_name"]} +
  • {get_html_project_link(new_r)} : new release - {new_r["release_tag"]} + {get_html_release_link(new_r)} available (old: {new_r["previous_tag"]}). (published {convert_date(new_r["published_date"])})
    • """ for new_p in new_projects: content += f""" -
  • {new_p["project_name"]} +
  • {get_html_project_link(new_p)} was added to your configuration. Last release: - {new_p["release_tag"]} + {get_html_release_link(new_p)} (published {convert_date(new_p["published_date"])})
    • """ with open(template_file, "r", encoding="utf-8") as f_template: @@ -114,6 +114,15 @@ def get_last_release(project): } +def get_html_project_link(el): + project_url = f'https://github.com/{el["project_name"]}' + return f'{el["project_name"]}' + + +def get_html_release_link(el): + return f'{el["release_tag"]}' + + def send_mail(content, config): smtp_port = config.get("smtp_port") smtp_server = config.get("smtp_server") diff --git a/template.html b/template.html index 60851ce..bfcd32c 100644 --- a/template.html +++ b/template.html @@ -1,66 +1,37 @@ - - - + + + - - - -

    - - Some new release on Github project available!

    -

    -
    - + + +
    +

    + + Some new release on Github project available! +

    +

    +

    +

    +