maxenceg2m/iTunes
1
0
Fork 0
Code Issues 2 Pull Requests Projects Releases Wiki Activity

ELS Service Refactor: extract method to treat hits buckets

Browse Source
This commit is contained in:
Maxence G. de Montauzan
2017-10-05 19:00:20 +02:00
parent 95f80b6b11
commit 50bc795d5f
1 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
dashboard/src/app/els.service.ts
View File

@@ -250,13 +250,7 @@ export class ElsService {
'size': 0 'size': 0
}), {headers: this.headers}) }), {headers: this.headers})
.map(res => res.json().aggregations.genres.buckets) .map(res => res.json().aggregations.genres.buckets)
.map((hits: Array<any>) => { .map((hits: Array<any>) => this.hitsToBuckets(hits));
const result: Array<Bucket> = [];
hits.forEach((bucket) => {
result.push(bucket);
});
return result;
});
} }
getGenreCount(): Observable<number> { getGenreCount(): Observable<number> {
@@ -299,14 +293,15 @@ export class ElsService {
'size': 0 'size': 0
}), {headers: this.headers}) }), {headers: this.headers})
.map(res => res.json().aggregations.album.buckets) .map(res => res.json().aggregations.album.buckets)
.map((hits: Array<any>) => { .map((hits: Array<any>) => this.hitsToBuckets(hits));
// TODO Refactor this duplicated code to a method }
private hitsToBuckets(hits: Array<any>): Bucket[] {
const result: Array<Bucket> = []; const result: Array<Bucket> = [];
hits.forEach((bucket) => { hits.forEach((bucket) => {
result.push(bucket); result.push(bucket);
}); });
return result; return result;
});
} }
private handleError(error: any): Promise<any> { private handleError(error: any): Promise<any> {