Mirroring/ltunify
1
0
Fork 0
mirror of https://github.com/Lekensteyn/ltunify.git synced 2025-12-08 17:53:23 +00:00
Code Issues Projects Releases Wiki Activity

Fix logic flaw in array bounds

Browse Source 
Index 0xFF needs an array of size 0x100... This error was caught with
Address Sanitizer while trying to iterate through all registers 0x00..0xFF.
This commit is contained in:
Peter Wu
2013-04-26 23:15:40 +02:00
parent 13ade9eb5b
commit 9e8da2dd01
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
hidraw.c
View File

@@ -50,7 +50,7 @@ struct report {
};
} __attribute__((__packed__));
static const char * report_types[0xFF] = {
static const char * report_types[0x100] = {
// 0x00 - 0x3F HID reports
[0x01] = "KEYBOARD",
[0x02] = "MOUSE",
@@ -78,7 +78,7 @@ static const char * report_types[0xFF] = {
[0x8F] = "_ERROR_MSG",
};
static const char * error_messages[0xFF] = {
static const char * error_messages[0x100] = {
// error messages for type=8F (ERROR_MSG)
[0x01] = "SUCCESS",
[0x02] = "INVALID_SUBID",
@@ -96,7 +96,7 @@ static const char * error_messages[0xFF] = {
};
// everything with a '?' is guessed
static const char * registers[0xFF] = {
static const char * registers[0x100] = {
[0x00] = "ENABLED_NOTIFS",
[0x01] = "KBD_HAND_DETECT?",
[0x02] = "CONNECTION_STATE",

4
ltunify.c
View File

@@ -197,7 +197,7 @@ struct device {
struct device devices[DEVICES_MAX];
// error messages for type=8F (ERROR_MSG)
static const char * error_messages[0xFF] = {
static const char * error_messages[0x100] = {
[0x01] = "SUCCESS",
[0x02] = "INVALID_SUBID",
[0x03] = "INVALID_ADDRESS",
@@ -213,7 +213,7 @@ static const char * error_messages[0xFF] = {
[0x0d] = "WRONG_PIN_CODE",
};
static const char * device_type[0x0F] = {
static const char * device_type[0x10] = {
[0x00] = "Unknown",
[0x01] = "Keyboard",
[0x02] = "Mouse",